This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (pacske() || sastel() || paes && ha == 0) {
...
...
// Pretend there is lots of code here
...
...
} else {
pheri();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ha != 0 || !paes) && !sastel() && !pacske()) {
pheri();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (elac > 0 && sarc() && riont() != 0) {
if (riont() != 0) {
return true;
}
if (sarc()) {
return true;
}
if (doun()) {
return true;
}
}
if (!oss) {
return true;
}
return false;
return !oss && (doun() || elac > 0) && sarc() && riont() != 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (oss) {
if (elac < 0 && !doun()) {
if (!sarc()) {
if (riont() == 0) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (pe == true) {
shecse();
}
if (sepo == false && pe != true) {
etoWhad();
}
if (ul == true && pe != true && sepo != false) {
isiPanen();
}
if (rord > o && pe != true && sepo != false && ul != true) {
cepad();
}
{
if (pe) {
shecse();
}
if (!sepo) {
etoWhad();
}
if (ul) {
isiPanen();
}
if (rord > o) {
cepad();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: