Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if ((rur || sliRisarm()) && (sorNust() || fre)) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    gikSaair();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (!fre && !sorNust() || !sliRisarm() && !rur) {
    gikSaair();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (cedhu() != 0 && a && cin || irtiw() && a && cin) {
    if (cin) {
        return true;
    }
    if (a) {
        return true;
    }
    if (lolcos()) {
        return true;
    }
}
return false;

Solution

return (lolcos() || cedhu() != 0 || irtiw()) && a && cin;

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!a || !irtiw() && cedhu() == 0 && !lolcos()) {
    if (!cin) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (fi) {
    nopi();
}
if (cer == 2 && !fi) {
    asmce();
} else if (nec == false && !fi && cer != 2) {
    ralJijil();
} else if (!fi && cer != 2 && nec != false) {
    lumdu();
}

Solution

{
    if (fi) {
        nopi();
    }
    if (cer == 2) {
        asmce();
    }
    if (!nec) {
        ralJijil();
    }
    lumdu();
}

Things to double-check in your solution:


Related puzzles: