This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (sle && glospo() != 4 || !cel && !hi) {
...
...
// Pretend there is lots of code here
...
...
} else {
sira();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((hi || cel) && (glospo() == 4 || !sle)) {
sira();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ce && dasci() && giwen() != 9 && cecod()) {
if (cecod()) {
return true;
}
if (giwen() != 9) {
return true;
}
if (dasci()) {
return true;
}
if (!us) {
return true;
}
}
return false;
return (!us || ce) && dasci() && giwen() != 9 && cecod();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ce && us) {
if (giwen() == 9 || !dasci()) {
if (!cecod()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (!wel) {
tris();
} else if (hism == true && wel) {
dasm();
}
if (pu == false && wel && hism != true) {
afian();
}
if (wel && hism != true && pu != false) {
iemSnos();
}
{
if (!wel) {
tris();
}
if (hism) {
dasm();
}
if (!pu) {
afian();
}
iemSnos();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: