This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ci && hioWhu() || !un) {
...
...
// Pretend there is lots of code here
...
...
} else {
xang();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (un && (!hioWhu() || !ci)) {
xang();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ir) {
if (me) {
if (uale()) {
return true;
}
if (!tei) {
return true;
}
}
}
return false;
return !tei && uale() || me || ir;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (tei) {
if (!uale()) {
return false;
}
}
if (!me) {
return false;
}
if (!ir) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (casi == true) {
idrad();
} else if (beh == 4 && casi != true) {
onma();
}
if (la <= 4 && casi != true && beh != 4) {
hosceu();
}
{
if (casi) {
idrad();
}
if (beh == 4) {
onma();
}
if (la <= 4) {
hosceu();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: