This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (paus == 0 && !riar && modvi()) {
...
...
// Pretend there is lots of code here
...
...
} else {
pecPipred();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!modvi() || riar || paus != 0) {
pecPipred();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (whass()) {
if (spess()) {
return true;
}
if (phlour()) {
return true;
}
if (hupsak()) {
return true;
}
}
return false;
return hupsak() && phlour() && spess() || whass();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!hupsak()) {
if (!phlour()) {
if (!spess()) {
return false;
}
}
}
if (!whass()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (cic == false) {
mudol();
} else if (pi == true && cic != false) {
wousm();
} else if (o == gnom && cic != false && pi != true) {
honsix();
}
{
if (!cic) {
mudol();
}
if (pi) {
wousm();
}
if (o == gnom) {
honsix();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: