This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!poba || zoen || we) {
...
...
// Pretend there is lots of code here
...
...
} else {
jibsma();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!we && !zoen && poba) {
jibsma();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (an == 3) {
if (adma == 2 || calem()) {
if (phin()) {
return true;
}
}
}
return false;
return phin() || adma == 2 || calem() || an == 3;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!phin()) {
return false;
}
if (adma != 2) {
return false;
}
if (!calem()) {
return false;
}
if (an != 3) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (pa == true) {
welEcarm();
} else if (shir == true && pa != true) {
truast();
}
if (lu == true && pa != true && shir != true) {
gewull();
}
{
if (pa) {
welEcarm();
}
if (shir) {
truast();
}
if (lu) {
gewull();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: