This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(pa == a) || o && whis) {
...
...
// Pretend there is lots of code here
...
...
} else {
sehist();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!whis || !o) && pa == a) {
sehist();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (moono() || re) {
if (igic) {
return true;
}
if (jucang()) {
return true;
}
}
return false;
return jucang() && igic || moono() || re;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!jucang()) {
if (!igic) {
return false;
}
}
if (!moono()) {
return false;
}
if (!re) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (prac == false) {
neras();
}
if (ol == false && prac != false) {
ecsVur();
} else if (prac != false && ol != false) {
cidmel();
}
{
if (!prac) {
neras();
}
if (!ol) {
ecsVur();
}
cidmel();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: