This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ungad() && !(tasec() || ceus != ceng)) {
...
...
// Pretend there is lots of code here
...
...
} else {
nalTuen();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (tasec() || ceus != ceng || ungad()) {
nalTuen();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (bada > 6 && seoSte() != ceos || dile) {
if (dile) {
if (seoSte() != ceos) {
return true;
}
}
if (zoil >= 1) {
return true;
}
}
return false;
return (zoil >= 1 || bada > 6) && (seoSte() != ceos || dile);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (bada < 6 && zoil <= 1) {
if (seoSte() == ceos) {
return false;
}
if (!dile) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (in >= il) {
phre();
}
if (esi == true && in <= il) {
efiSas();
}
if (!poep && in <= il && esi != true) {
kedest();
}
{
if (in >= il) {
phre();
}
if (esi) {
efiSas();
}
if (!poep) {
kedest();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: