This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((re || emfant()) && ostOnstro()) {
...
...
// Pretend there is lots of code here
...
...
} else {
lasm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ostOnstro() || !emfant() && !re) {
lasm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pemFaont() < 9) {
return true;
}
if (o < 7) {
return true;
}
if (pu == 4) {
return true;
}
if (eeePraril()) {
return true;
}
return false;
return eeePraril() && pu == 4 && o < 7 && pemFaont() < 9;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (o > 7 || pu != 4 || !eeePraril()) {
if (pemFaont() > 9) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (el <= 1) {
tiplir();
}
if (er > fis && el >= 1) {
racEstbau();
} else if (bi != 5 && el >= 1 && er < fis) {
beir();
}
{
if (el <= 1) {
tiplir();
}
if (er > fis) {
racEstbau();
}
if (bi != 5) {
beir();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: