This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (sas != 8 && !(e == 7 || un)) {
...
...
// Pretend there is lots of code here
...
...
} else {
catu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (e == 7 || un || sas == 8) {
catu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cicOnu()) {
if (lio && facba()) {
if (spe) {
return true;
}
}
}
return false;
return spe || lio && facba() || cicOnu();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!lio && !spe) {
if (!spe) {
return false;
}
if (!facba()) {
return false;
}
}
if (!cicOnu()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (eso > 2 == true) {
frair();
}
if (ca == false && eso > 2 != true) {
chuc();
}
if (!cio && eso > 2 != true && ca != false) {
chohia();
}
{
if (eso > 2) {
frair();
}
if (!ca) {
chuc();
}
if (!cio) {
chohia();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: