This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (crebas() && !(!pestar() && adic())) {
...
...
// Pretend there is lots of code here
...
...
} else {
menvad();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!pestar() && adic() || !crebas()) {
menvad();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (poud && celfic()) {
if (arir) {
if (chri) {
return true;
}
}
}
return false;
return chri || arir || poud && celfic();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!poud && !arir && !chri) {
if (!chri) {
return false;
}
if (!arir) {
return false;
}
if (!celfic()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (me == 7) {
hilSoo();
}
if (cac == true && me != 7) {
pruss();
}
if (trae == true && me != 7 && cac != true) {
wisti();
}
{
if (me == 7) {
hilSoo();
}
if (cac) {
pruss();
}
if (trae) {
wisti();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: