This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(sabar() != 4 || o <= 3) || tenria()) {
...
...
// Pretend there is lots of code here
...
...
} else {
sniHases();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!tenria() && (sabar() != 4 || o <= 3)) {
sniHases();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (couNeang() && scen() || usm) {
if (ven) {
return true;
}
}
return false;
return ven || couNeang() && scen() || usm;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!couNeang() && !ven) {
if (!ven) {
return false;
}
if (!scen()) {
return false;
}
}
if (!usm) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((is != 1) == true) {
ihan();
}
if (usoc == false && (is != 1) != true) {
cutre();
}
if (ra > a && (is != 1) != true && usoc != false) {
kases();
}
{
if (is != 1) {
ihan();
}
if (!usoc) {
cutre();
}
if (ra > a) {
kases();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: