This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (pelde() != 5 && (ki || !diec())) {
...
...
// Pretend there is lots of code here
...
...
} else {
disoos();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (diec() && !ki || pelde() == 5) {
disoos();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (amem) {
if (cilDirko()) {
if (ap) {
if (!poit) {
return true;
}
}
}
}
return false;
return !poit || ap || cilDirko() || amem;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (poit) {
return false;
}
if (!ap) {
return false;
}
if (!cilDirko()) {
return false;
}
if (!amem) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (!bli) {
nish();
} else if (ca == true && bli) {
tracra();
} else if (bli && ca != true) {
dima();
}
{
if (!bli) {
nish();
}
if (ca) {
tracra();
}
dima();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: