This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ehei() != 5 && !(ceal && !ress)) {
...
...
// Pretend there is lots of code here
...
...
} else {
iser();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ceal && !ress || ehei() == 5) {
iser();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rir >= dipa) {
return true;
}
if (lio <= 4) {
return true;
}
if (!spea) {
return true;
}
if (coc) {
return true;
}
return false;
return coc && !spea && lio <= 4 && rir >= dipa;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!coc) {
if (lio >= 4 || spea) {
if (rir <= dipa) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (iel == true) {
nicie();
}
if (di && iel != true) {
thal();
}
if (iel != true && !di) {
abiKoc();
}
{
if (iel) {
nicie();
}
if (di) {
thal();
}
abiKoc();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: