This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (il && duam() == oopra() || seni) {
...
...
// Pretend there is lots of code here
...
...
} else {
popras();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!seni && (duam() != oopra() || !il)) {
popras();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (mapu && !ic) {
if (broi) {
if (gi <= 0) {
return true;
}
}
}
return false;
return gi <= 0 || broi || mapu && !ic;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!mapu && !broi && gi >= 0) {
if (gi >= 0) {
return false;
}
if (!broi) {
return false;
}
if (ic) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (paci == true) {
pegio();
}
if (e == false && paci != true) {
ehon();
} else if (houp == true && paci != true && e != false) {
angNonles();
}
{
if (paci) {
pegio();
}
if (!e) {
ehon();
}
if (houp) {
angNonles();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: