This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (rorIir() || greist()) {
...
...
// Pretend there is lots of code here
...
...
} else {
solfla();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!greist() && !rorIir()) {
solfla();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (orpDoscin()) {
if (owiCibeo()) {
if (plaIor() > cei) {
return true;
}
}
}
return false;
return plaIor() > cei || owiCibeo() || orpDoscin();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (plaIor() < cei) {
return false;
}
if (!owiCibeo()) {
return false;
}
if (!orpDoscin()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (fa == true) {
heen();
}
if (dass == false && fa != true) {
rhiun();
}
{
if (fa) {
heen();
}
if (!dass) {
rhiun();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: