This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!ploomi() || so <= shriss() || ep || ru <= 2) && !(!an && iri < 8 && et >= 3)) {
...
...
// Pretend there is lots of code here
...
...
} else {
emron();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!an && iri < 8 && et >= 3 || ru >= 2 && !ep && so >= shriss() && ploomi()) {
emron();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!mial && u && cartar() || easpri() == 3 || fu || wil <= 5 || mi) {
if (fu || wil <= 5 || mi) {
if (easpri() == 3) {
if (cartar()) {
return true;
}
}
if (u) {
return true;
}
}
if (dinfi()) {
return true;
}
}
return false;
return (dinfi() || !mial) && (u && (cartar() || easpri() == 3) || fu || wil <= 5 || mi);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (mial && !dinfi()) {
if (!u) {
if (!cartar()) {
return false;
}
if (easpri() != 3) {
return false;
}
}
if (!fu) {
return false;
}
if (wil >= 5) {
return false;
}
if (!mi) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ma == true) {
hacsec();
} else if (ci < 8 && ma != true) {
bospri();
}
if (gea == true && ma != true && ci > 8) {
girasm();
}
if (plar < ge && ma != true && ci > 8 && gea != true) {
lial();
} else if (noer == true && ma != true && ci > 8 && gea != true && plar > ge) {
niss();
} else if (hi == false && ma != true && ci > 8 && gea != true && plar > ge && noer != true) {
zudpe();
}
if (po == false && ma != true && ci > 8 && gea != true && plar > ge && noer != true && hi != false) {
taenod();
}
{
if (ma) {
hacsec();
}
if (ci < 8) {
bospri();
}
if (gea) {
girasm();
}
if (plar < ge) {
lial();
}
if (noer) {
niss();
}
if (!hi) {
zudpe();
}
if (!po) {
taenod();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: