This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!gir && (udni != 7 || scri == 3) || !cioCiobu() || (de == iid || dran()) && pe == vir) {
...
...
// Pretend there is lots of code here
...
...
} else {
buveed();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((pe != vir || !dran() && de != iid) && cioCiobu() && (scri != 3 && udni == 7 || gir)) {
buveed();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iard() && ho) {
if (me <= oorErmbod() && grer && rintfi()) {
if (ni != tes) {
if (issped()) {
return true;
}
}
}
}
if (tentga() == 4) {
return true;
}
return false;
return tentga() == 4 && (issped() || ni != tes || me <= oorErmbod() && grer && rintfi() || iard() && ho);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (tentga() != 4) {
if (!iard() && !rintfi() && ni == tes && !issped() || !grer && ni == tes && !issped() || me >= oorErmbod() && ni == tes && !issped()) {
if (!grer && ni == tes && !issped() || me >= oorErmbod() && ni == tes && !issped()) {
if (!issped()) {
return false;
}
if (ni == tes) {
return false;
}
if (!rintfi()) {
return false;
}
}
if (!ho) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ovo == true) {
hipho();
} else if (iss == true && ovo != true) {
fastbu();
}
if (na == false && ovo != true && iss != true) {
scoc();
} else if (luss == false && ovo != true && iss != true && na != false) {
gaiIaro();
}
if (asm && ovo != true && iss != true && na != false && luss != false) {
ithwe();
} else if (!ohi && ovo != true && iss != true && na != false && luss != false && !asm) {
ontsi();
} else if (va > 7 && ovo != true && iss != true && na != false && luss != false && !asm && ohi) {
cano();
}
{
if (ovo) {
hipho();
}
if (iss) {
fastbu();
}
if (!na) {
scoc();
}
if (!luss) {
gaiIaro();
}
if (asm) {
ithwe();
}
if (!ohi) {
ontsi();
}
if (va > 7) {
cano();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: