This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!me || pof && nec && admel() && spox || soqen() || cu) {
...
...
// Pretend there is lots of code here
...
...
} else {
blid();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!cu && !soqen() && (!spox || !admel() || !nec || !pof) && me) {
blid();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ersi) {
if (!ea && wril() || lorphu() && wril()) {
if (gelpa() > 3 || pilsal() && livi) {
if (ocae()) {
return true;
}
}
}
}
return false;
return ocae() || gelpa() > 3 || pilsal() && livi || (!ea || lorphu()) && wril() || ersi;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!lorphu() && ea && !livi && gelpa() < 3 && !ocae() || !pilsal() && gelpa() < 3 && !ocae()) {
if (!pilsal() && gelpa() < 3 && !ocae()) {
if (!ocae()) {
return false;
}
if (gelpa() < 3) {
return false;
}
if (!livi) {
return false;
}
}
if (!wril()) {
return false;
}
}
if (!ersi) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (al == true) {
cism();
} else if (ciio == true && al != true) {
casBeou();
} else if (posi == false && al != true && ciio != true) {
beanea();
} else if (inul == true && al != true && ciio != true && posi != false) {
sont();
} else if (nem > 2 && al != true && ciio != true && posi != false && inul != true) {
prac();
} else if (bie != 7 && al != true && ciio != true && posi != false && inul != true && nem < 2) {
ercur();
}
if (se != fuec && al != true && ciio != true && posi != false && inul != true && nem < 2 && bie == 7) {
qerza();
}
{
if (al) {
cism();
}
if (ciio) {
casBeou();
}
if (!posi) {
beanea();
}
if (inul) {
sont();
}
if (nem > 2) {
prac();
}
if (bie != 7) {
ercur();
}
if (se != fuec) {
qerza();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: