This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!iir && !sose && to || prax && !(alcha() >= ed) && !ioor && !un) {
...
...
// Pretend there is lots of code here
...
...
} else {
suaSempru();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((un || ioor || alcha() >= ed || !prax) && (!to || sose || iir)) {
suaSempru();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!i || afrur()) {
if (vismci()) {
if (cing) {
if (aess) {
return true;
}
}
}
if (sism) {
return true;
}
if (miol()) {
return true;
}
if (peoCiss()) {
return true;
}
}
return false;
return peoCiss() && miol() && sism && (aess || cing || vismci()) || !i || afrur();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!sism || !miol() || !peoCiss()) {
if (!aess) {
return false;
}
if (!cing) {
return false;
}
if (!vismci()) {
return false;
}
}
if (i) {
return false;
}
if (!afrur()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((agil != od) == true) {
brerwe();
}
if (snes == false && (agil != od) != true) {
seos();
} else if (favu == true && (agil != od) != true && snes != false) {
phozor();
}
if (!di && (agil != od) != true && snes != false && favu != true) {
vaup();
} else if (qil == true && (agil != od) != true && snes != false && favu != true && di) {
tesam();
}
if (miir && (agil != od) != true && snes != false && favu != true && di && qil != true) {
waeste();
} else if ((agil != od) != true && snes != false && favu != true && di && qil != true && !miir) {
stiarp();
}
{
if (agil != od) {
brerwe();
}
if (!snes) {
seos();
}
if (favu) {
phozor();
}
if (!di) {
vaup();
}
if (qil) {
tesam();
}
if (miir) {
waeste();
}
stiarp();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: