This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (hiol() && ick != ceri() && (!ti || es) && !(te && !beox || ocrunt())) {
...
...
// Pretend there is lots of code here
...
...
} else {
efel();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (te && !beox || ocrunt() || !es && ti || ick == ceri() || !hiol()) {
efel();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!a || hoec) {
if (pem && entsim() && itri == 9 && ap || shass()) {
if (o) {
return true;
}
}
}
return false;
return o || pem && entsim() && (itri == 9 && ap || shass()) || !a || hoec;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!entsim() && !o || !pem && !o) {
if (itri != 9 && !o) {
if (!o) {
return false;
}
if (!ap) {
return false;
}
}
if (!shass()) {
return false;
}
}
if (a) {
return false;
}
if (!hoec) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (!ca) {
swes();
} else if (be == true && ca) {
iroSpo();
} else if (noss == true && ca && be != true) {
denod();
}
if (anch == false && ca && be != true && noss != true) {
iadspo();
}
if (poo == false && ca && be != true && noss != true && anch != false) {
gapsem();
} else if (sle && ca && be != true && noss != true && anch != false && poo != false) {
dehess();
}
if (tras == true && ca && be != true && noss != true && anch != false && poo != false && !sle) {
cosso();
}
{
if (!ca) {
swes();
}
if (be) {
iroSpo();
}
if (noss) {
denod();
}
if (!anch) {
iadspo();
}
if (!poo) {
gapsem();
}
if (sle) {
dehess();
}
if (tras) {
cosso();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: