This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(o && (!he || ar == 3) && ti >= 9) || !e || ni || mex) {
...
...
// Pretend there is lots of code here
...
...
} else {
tashos();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!mex && !ni && e && o && (!he || ar == 3) && ti >= 9) {
tashos();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rhi && hul && isspea() && hurtho()) {
if (skeli() && sii) {
if (hoci >= anchun()) {
return true;
}
}
if (aed > giss) {
return true;
}
}
return false;
return aed > giss && (hoci >= anchun() || skeli() && sii) || rhi && hul && isspea() && hurtho();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!hul && !sii && hoci <= anchun() || !skeli() && hoci <= anchun() || aed < giss || !rhi && !sii && hoci <= anchun() || !skeli() && hoci <= anchun() || aed < giss) {
if (!isspea() && !sii && hoci <= anchun() || !skeli() && hoci <= anchun() || aed < giss) {
if (aed < giss) {
if (!skeli() && hoci <= anchun()) {
if (hoci <= anchun()) {
return false;
}
if (!sii) {
return false;
}
}
}
if (!hurtho()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (i == true) {
cuvi();
}
if ((ubid < co) == true && i != true) {
bitos();
} else if (hu == true && i != true && (ubid < co) != true) {
odpox();
}
if (dax == false && i != true && (ubid < co) != true && hu != true) {
paeBre();
} else if (as == true && i != true && (ubid < co) != true && hu != true && dax != false) {
cial();
} else if (tes == false && i != true && (ubid < co) != true && hu != true && dax != false && as != true) {
sasPripac();
} else if (geen && i != true && (ubid < co) != true && hu != true && dax != false && as != true && tes != false) {
mavia();
}
{
if (i) {
cuvi();
}
if (ubid < co) {
bitos();
}
if (hu) {
odpox();
}
if (!dax) {
paeBre();
}
if (as) {
cial();
}
if (!tes) {
sasPripac();
}
if (geen) {
mavia();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: