This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (arpang() || ce != sneph() || !ci || at == e && (di && !pe || ictcad() != 1)) {
...
...
// Pretend there is lots of code here
...
...
} else {
truiol();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ictcad() == 1 && (pe || !di) || at != e) && ci && ce == sneph() && !arpang()) {
truiol();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (asma() && emia() && plo <= 3 || vinhar()) {
if (ae && plo <= 3 || vinhar()) {
if (ma && plo <= 3 || vinhar()) {
if (vinhar()) {
if (plo <= 3) {
return true;
}
}
if (cadhun()) {
return true;
}
}
}
}
if (vec < 4) {
return true;
}
return false;
return vec < 4 && (cadhun() || ma || ae || asma() && emia()) && (plo <= 3 || vinhar());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (vec > 4) {
if (!emia() && !ae && !ma && !cadhun() || !asma() && !ae && !ma && !cadhun()) {
if (plo >= 3) {
return false;
}
if (!vinhar()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ge == true) {
aelt();
}
if (jir == true && ge != true) {
priGroce();
} else if (u == true && ge != true && jir != true) {
grirho();
}
if (anve > 8 && ge != true && jir != true && u != true) {
asoFier();
}
if (vo == true && ge != true && jir != true && u != true && anve < 8) {
baimin();
} else if (omac != 2 && ge != true && jir != true && u != true && anve < 8 && vo != true) {
ricdal();
} else if (ge != true && jir != true && u != true && anve < 8 && vo != true && omac == 2) {
dadad();
}
{
if (ge) {
aelt();
}
if (jir) {
priGroce();
}
if (u) {
grirho();
}
if (anve > 8) {
asoFier();
}
if (vo) {
baimin();
}
if (omac != 2) {
ricdal();
}
dadad();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: