This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (fadow() || figal() || !(!lus && leuss()) && (sor || miadfi() < vo || !mi)) {
...
...
// Pretend there is lots of code here
...
...
} else {
osmas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((mi && miadfi() > vo && !sor || !lus && leuss()) && !figal() && !fadow()) {
osmas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (elvi) {
if (sacme()) {
return true;
}
}
if (clihan()) {
return true;
}
if (u) {
return true;
}
if (docoud()) {
return true;
}
if (mushim()) {
return true;
}
if (gla) {
return true;
}
if (!gi) {
return true;
}
return false;
return !gi && gla && mushim() && docoud() && u && clihan() && (sacme() || elvi);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!clihan() || !u || !docoud() || !mushim() || !gla || gi) {
if (!sacme()) {
return false;
}
if (!elvi) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (feam == true) {
plioc();
} else if (!siu && feam != true) {
stePle();
} else if (cioc == false && feam != true && siu) {
droMuac();
} else if (!po && feam != true && siu && cioc != false) {
pioTiesen();
} else if (pif == true && feam != true && siu && cioc != false && po) {
cafre();
}
if (!susm && feam != true && siu && cioc != false && po && pif != true) {
osdesm();
}
if (gec == true && feam != true && siu && cioc != false && po && pif != true && susm) {
desco();
}
{
if (feam) {
plioc();
}
if (!siu) {
stePle();
}
if (!cioc) {
droMuac();
}
if (!po) {
pioTiesen();
}
if (pif) {
cafre();
}
if (!susm) {
osdesm();
}
if (gec) {
desco();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: