This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!molf || qismpu() || !im || bellwa() < ahoc) && !(hofur() || pides()) || ruco) {
...
...
// Pretend there is lots of code here
...
...
} else {
rolSpija();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ruco && (hofur() || pides() || !molf || qismpu() || !im || bellwa() < ahoc)) {
rolSpija();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (gesh || ce || oss >= remo) {
if (barmci() && flae && iooEssnep() || brapar() && iooEssnep()) {
if (iooEssnep()) {
return true;
}
if (phrorm()) {
return true;
}
}
}
return false;
return (phrorm() || barmci() && (flae || brapar())) && iooEssnep() || gesh || ce || oss >= remo;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!brapar() && !flae && !phrorm() || !barmci() && !phrorm()) {
if (!iooEssnep()) {
return false;
}
}
if (!gesh) {
return false;
}
if (!ce) {
return false;
}
if (oss <= remo) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (da) {
kandda();
}
if (vune != 9 && !da) {
gebaul();
} else if (qoss == false && !da && vune == 9) {
cilang();
}
if (phus <= 7 && !da && vune == 9 && qoss != false) {
paeRire();
}
if (ved == true && !da && vune == 9 && qoss != false && phus >= 7) {
deron();
}
if (ohes == true && !da && vune == 9 && qoss != false && phus >= 7 && ved != true) {
vebten();
}
if (bi == true && !da && vune == 9 && qoss != false && phus >= 7 && ved != true && ohes != true) {
crius();
}
{
if (da) {
kandda();
}
if (vune != 9) {
gebaul();
}
if (!qoss) {
cilang();
}
if (phus <= 7) {
paeRire();
}
if (ved) {
deron();
}
if (ohes) {
vebten();
}
if (bi) {
crius();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: