This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(pi == 1) && fegHiont() && ang != 4 && ma > 4 && stangi() == 1 && !(rewo() && sose())) {
...
...
// Pretend there is lots of code here
...
...
} else {
cael();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (rewo() && sose() || stangi() != 1 || ma < 4 || ang == 4 || !fegHiont() || pi == 1) {
cael();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (fuiIsta() != pedce() && !fis || ealfid() && iverk() || heno || uac || pimb) {
if (broen()) {
return true;
}
}
return false;
return broen() || fuiIsta() != pedce() && !fis || ealfid() && iverk() || heno || uac || pimb;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ealfid() && fis && !broen() || fuiIsta() == pedce() && !broen()) {
if (fuiIsta() == pedce() && !broen()) {
if (!broen()) {
return false;
}
if (fis) {
return false;
}
}
if (!iverk()) {
return false;
}
}
if (!heno) {
return false;
}
if (!uac) {
return false;
}
if (!pimb) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((nes == 6) == true) {
shig();
} else if (po == true && (nes == 6) != true) {
fourt();
} else if (pher < 4 && (nes == 6) != true && po != true) {
stru();
} else if (ce && (nes == 6) != true && po != true && pher > 4) {
caioc();
} else if (be != 5 && (nes == 6) != true && po != true && pher > 4 && !ce) {
elirn();
} else if (le < sacu && (nes == 6) != true && po != true && pher > 4 && !ce && be == 5) {
eler();
} else if (coxu == true && (nes == 6) != true && po != true && pher > 4 && !ce && be == 5 && le > sacu) {
mohae();
}
{
if (nes == 6) {
shig();
}
if (po) {
fourt();
}
if (pher < 4) {
stru();
}
if (ce) {
caioc();
}
if (be != 5) {
elirn();
}
if (le < sacu) {
eler();
}
if (coxu) {
mohae();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: