This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!((howleu() || gesos() >= 6 || a || pris) && ceterd() >= 6 && somEpne() == mo) && cic >= stiGixoic()) {
...
...
// Pretend there is lots of code here
...
...
} else {
uinIcdurt();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (cic <= stiGixoic() || (howleu() || gesos() >= 6 || a || pris) && ceterd() >= 6 && somEpne() == mo) {
uinIcdurt();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (spost() && pril() != cotil() || iicOsm() && pril() != cotil() || crou != isil && da) {
if (osde() == oa && iden()) {
if (oang < 0) {
return true;
}
}
}
return false;
return oang < 0 || osde() == oa && iden() || (spost() || iicOsm()) && pril() != cotil() || crou != isil && da;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (crou == isil && pril() == cotil() && !iden() && oang > 0 || osde() != oa && oang > 0 || !iicOsm() && !spost() && !iden() && oang > 0 || osde() != oa && oang > 0) {
if (!iicOsm() && !spost() && !iden() && oang > 0 || osde() != oa && oang > 0) {
if (osde() != oa && oang > 0) {
if (oang > 0) {
return false;
}
if (!iden()) {
return false;
}
}
if (pril() == cotil()) {
return false;
}
}
if (!da) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (tant == true) {
fastur();
} else if (he == false && tant != true) {
uler();
} else if (an >= 8 && tant != true && he != false) {
vesTiprel();
} else if (rast && tant != true && he != false && an <= 8) {
canho();
}
if (snu == false && tant != true && he != false && an <= 8 && !rast) {
phles();
}
if (ii && tant != true && he != false && an <= 8 && !rast && snu != false) {
incist();
} else if (euud == false && tant != true && he != false && an <= 8 && !rast && snu != false && !ii) {
cerost();
}
{
if (tant) {
fastur();
}
if (!he) {
uler();
}
if (an >= 8) {
vesTiprel();
}
if (rast) {
canho();
}
if (!snu) {
phles();
}
if (ii) {
incist();
}
if (!euud) {
cerost();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: