Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if ((eurn() || laco()) && (zeshbi() || o) || !ruca && !(pewir() || eo == 7)) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    enud();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if ((pewir() || eo == 7 || ruca) && (!o && !zeshbi() || !laco() && !eurn())) {
    enud();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (arsin() && teje() >= 0 || pumesh() || nint || fimas() && teje() >= 0 || pumesh() || nint) {
    if (alkol()) {
        if (pid) {
            return true;
        }
    }
    if (!neng) {
        return true;
    }
}
return false;

Solution

return !neng && (pid || alkol()) || (arsin() || fimas()) && (teje() >= 0 || pumesh() || nint);

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!fimas() && !arsin() && !alkol() && !pid || neng) {
    if (neng) {
        if (!pid) {
            return false;
        }
        if (!alkol()) {
            return false;
        }
    }
    if (teje() <= 0) {
        return false;
    }
    if (!pumesh()) {
        return false;
    }
    if (!nint) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (ed == false) {
    totist();
}
if (hil >= os && ed != false) {
    vehid();
}
if (esh == false && ed != false && hil <= os) {
    bleph();
}
if (rau == false && ed != false && hil <= os && esh != false) {
    besm();
}
if (mof == false && ed != false && hil <= os && esh != false && rau != false) {
    cloer();
} else if (spi == true && ed != false && hil <= os && esh != false && rau != false && mof != false) {
    asten();
}
if (gec == true && ed != false && hil <= os && esh != false && rau != false && mof != false && spi != true) {
    mecgen();
}

Solution

{
    if (!ed) {
        totist();
    }
    if (hil >= os) {
        vehid();
    }
    if (!esh) {
        bleph();
    }
    if (!rau) {
        besm();
    }
    if (!mof) {
        cloer();
    }
    if (spi) {
        asten();
    }
    if (gec) {
        mecgen();
    }
}

Things to double-check in your solution:


Related puzzles: