This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((sliAurmi() || !meph && !re) && !(pral() <= 5) && (el || lossci() == 8) && !fre) {
...
...
// Pretend there is lots of code here
...
...
} else {
nieAcol();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (fre || lossci() != 8 && !el || pral() <= 5 || (re || meph) && !sliAurmi()) {
nieAcol();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (resis() && busa) {
if (jume && sucRastda() == idor || elso || xatpru() || ranan()) {
if (atec < al) {
return true;
}
}
}
return false;
return atec < al || jume && (sucRastda() == idor || elso || xatpru() || ranan()) || resis() && busa;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!resis() && !ranan() && !xatpru() && !elso && sucRastda() != idor && atec > al || !jume && atec > al) {
if (!jume && atec > al) {
if (atec > al) {
return false;
}
if (sucRastda() != idor) {
return false;
}
if (!elso) {
return false;
}
if (!xatpru()) {
return false;
}
if (!ranan()) {
return false;
}
}
if (!busa) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ma == true) {
isgir();
}
if (ner > 1 && ma != true) {
splas();
} else if (lalt == 1 && ma != true && ner < 1) {
iulism();
} else if (eck == fi && ma != true && ner < 1 && lalt != 1) {
striss();
}
if (du == 0 && ma != true && ner < 1 && lalt != 1 && eck != fi) {
sasIount();
}
if ((ep != es) == true && ma != true && ner < 1 && lalt != 1 && eck != fi && du != 0) {
jesm();
}
if (apro == ba && ma != true && ner < 1 && lalt != 1 && eck != fi && du != 0 && (ep != es) != true) {
lodus();
}
{
if (ma) {
isgir();
}
if (ner > 1) {
splas();
}
if (lalt == 1) {
iulism();
}
if (eck == fi) {
striss();
}
if (du == 0) {
sasIount();
}
if (ep != es) {
jesm();
}
if (apro == ba) {
lodus();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: