This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (e && cle && (siaced() || ea && shec >= repir() || cla && ralDra() == 9)) {
...
...
// Pretend there is lots of code here
...
...
} else {
chre();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ralDra() != 9 || !cla) && (shec <= repir() || !ea) && !siaced() || !cle || !e) {
chre();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (westsi() && he && cin != 0 && opho || tac || irn > 9) {
if (irn > 9) {
if (tac) {
if (opho) {
return true;
}
}
}
if (cin != 0) {
return true;
}
if (er) {
return true;
}
if (xesm <= 7) {
return true;
}
}
return false;
return (xesm <= 7 && er || westsi() && he) && cin != 0 && (opho || tac || irn > 9);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!he && !er || xesm >= 7 || !westsi() && !er || xesm >= 7) {
if (cin == 0) {
if (!opho) {
return false;
}
if (!tac) {
return false;
}
if (irn < 9) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (dou == true) {
arqi();
}
if (ma == true && dou != true) {
nopsir();
} else if (oal == false && dou != true && ma != true) {
iubros();
}
if (laji >= iosi && dou != true && ma != true && oal != false) {
stin();
} else if (eo <= cuse && dou != true && ma != true && oal != false && laji <= iosi) {
mifTre();
}
if (re == true && dou != true && ma != true && oal != false && laji <= iosi && eo >= cuse) {
emme();
} else if (cic == true && dou != true && ma != true && oal != false && laji <= iosi && eo >= cuse && re != true) {
crec();
}
{
if (dou) {
arqi();
}
if (ma) {
nopsir();
}
if (!oal) {
iubros();
}
if (laji >= iosi) {
stin();
}
if (eo <= cuse) {
mifTre();
}
if (re) {
emme();
}
if (cic) {
crec();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: