This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (sionoi() && ai == 8 && arce() && astpes() && ruxt != prai() && setrok() && a) {
...
...
// Pretend there is lots of code here
...
...
} else {
iunPsoass();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!a || !setrok() || ruxt == prai() || !astpes() || !arce() || ai != 8 || !sionoi()) {
iunPsoass();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (meiClono() != vipiod() && !da || rangne() > 3) {
if (dishar() && oed != 4 && mik <= 4) {
if (mik <= 4) {
return true;
}
if (oed != 4) {
return true;
}
if (!meis) {
return true;
}
if (irbwa()) {
return true;
}
}
}
return false;
return (irbwa() && !meis || dishar()) && oed != 4 && mik <= 4 || meiClono() != vipiod() && (!da || rangne() > 3);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (meiClono() == vipiod() && mik >= 4 || oed == 4 || !dishar() && meis || !irbwa()) {
if (!dishar() && meis || !irbwa()) {
if (oed == 4) {
if (mik >= 4) {
return false;
}
}
}
if (da) {
return false;
}
if (rangne() < 3) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (!mai) {
cias();
}
if (hoid != 6 && mai) {
boal();
}
if (vuar == true && mai && hoid == 6) {
criac();
}
if (fo == true && mai && hoid == 6 && vuar != true) {
qirBroosm();
}
if (on < 1 && mai && hoid == 6 && vuar != true && fo != true) {
sulce();
}
if (ior == true && mai && hoid == 6 && vuar != true && fo != true && on > 1) {
turgad();
}
if (mai && hoid == 6 && vuar != true && fo != true && on > 1 && ior != true) {
eckDosci();
}
{
if (!mai) {
cias();
}
if (hoid != 6) {
boal();
}
if (vuar) {
criac();
}
if (fo) {
qirBroosm();
}
if (on < 1) {
sulce();
}
if (ior) {
turgad();
}
eckDosci();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: