This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (as > ced || (coa >= mo && iwe || sidiss() < 9) && (keng() || earral()) && fal == i) {
...
...
// Pretend there is lots of code here
...
...
} else {
driSuresm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((fal != i || !earral() && !keng() || sidiss() > 9 && (!iwe || coa <= mo)) && as < ced) {
driSuresm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ceng && osm && elpic() != 9 && mec != 2 || !poft && osm && elpic() != 9 && mec != 2) {
if (!enat && pe > 8 && elpic() != 9 && mec != 2) {
if (mec != 2) {
return true;
}
if (elpic() != 9) {
return true;
}
if (edbo) {
return true;
}
}
}
return false;
return (edbo || !enat && pe > 8 || (!ceng || !poft) && osm) && elpic() != 9 && mec != 2;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!osm && pe < 8 && !edbo || enat && !edbo || poft && ceng && pe < 8 && !edbo || enat && !edbo) {
if (elpic() == 9) {
if (mec == 2) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (e == id) {
pucPourm();
}
if (noss == 7 && e != id) {
pleei();
}
if (glal == 2 == true && e != id && noss != 7) {
toscha();
}
if (wo == true && e != id && noss != 7 && glal == 2 != true) {
gilus();
} else if (poc == true && e != id && noss != 7 && glal == 2 != true && wo != true) {
tricam();
}
if (us == true && e != id && noss != 7 && glal == 2 != true && wo != true && poc != true) {
pheEssas();
}
if (e != id && noss != 7 && glal == 2 != true && wo != true && poc != true && us != true) {
entti();
}
{
if (e == id) {
pucPourm();
}
if (noss == 7) {
pleei();
}
if (glal == 2) {
toscha();
}
if (wo) {
gilus();
}
if (poc) {
tricam();
}
if (us) {
pheEssas();
}
entti();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: