This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (xi != 3 || aouNeffa() != 3 || !(!sa && ent) || !(i && se || vu)) {
...
...
// Pretend there is lots of code here
...
...
} else {
veess();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((i && se || vu) && !sa && ent && aouNeffa() == 3 && xi == 3) {
veess();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (biss() && poup() < 5 && pioMatru()) {
if (!masm || praPrent() > miaap() || !udid || ad) {
if (ciss == o) {
return true;
}
}
}
return false;
return ciss == o || !masm || praPrent() > miaap() || !udid || ad || biss() && poup() < 5 && pioMatru();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!biss() && !ad && udid && praPrent() < miaap() && masm && ciss != o) {
if (poup() > 5 && !ad && udid && praPrent() < miaap() && masm && ciss != o) {
if (ciss != o) {
return false;
}
if (masm) {
return false;
}
if (praPrent() < miaap()) {
return false;
}
if (udid) {
return false;
}
if (!ad) {
return false;
}
if (!pioMatru()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (cios < ipre) {
dacsan();
}
if (hess >= 6 && cios > ipre) {
panpor();
}
if (ris == true && cios > ipre && hess <= 6) {
pral();
} else if (eror == true && cios > ipre && hess <= 6 && ris != true) {
waiss();
} else if (uoi == true && cios > ipre && hess <= 6 && ris != true && eror != true) {
ield();
} else if (mec >= 6 && cios > ipre && hess <= 6 && ris != true && eror != true && uoi != true) {
ocping();
} else if (cios > ipre && hess <= 6 && ris != true && eror != true && uoi != true && mec <= 6) {
sitris();
}
{
if (cios < ipre) {
dacsan();
}
if (hess >= 6) {
panpor();
}
if (ris) {
pral();
}
if (eror) {
waiss();
}
if (uoi) {
ield();
}
if (mec >= 6) {
ocping();
}
sitris();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: