This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (((be == 5 || sut || cuc) && ic != wushou() || eka != 5 || nallre()) && pe) {
...
...
// Pretend there is lots of code here
...
...
} else {
mapra();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!pe || !nallre() && eka == 5 && (ic == wushou() || !cuc && !sut && be != 5)) {
mapra();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (sieu() && cophol() && i && togn && ra != tro) {
if (ra != tro) {
return true;
}
if (togn) {
return true;
}
if (i) {
return true;
}
if (cophol()) {
return true;
}
if (is) {
return true;
}
}
if (!gaid) {
return true;
}
if (!sle) {
return true;
}
return false;
return !sle && !gaid && (is || sieu()) && cophol() && i && togn && ra != tro;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!i || !cophol() || !sieu() && !is || gaid || sle) {
if (!togn) {
if (ra == tro) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ibin == false) {
ceslin();
} else if (pren == true && ibin != false) {
iosoul();
} else if (oss == true && ibin != false && pren != true) {
winoin();
}
if ((re == 9) == true && ibin != false && pren != true && oss != true) {
necor();
}
if (ce == false && ibin != false && pren != true && oss != true && (re == 9) != true) {
isses();
} else if (iong == true && ibin != false && pren != true && oss != true && (re == 9) != true && ce != false) {
bian();
}
if (ibin != false && pren != true && oss != true && (re == 9) != true && ce != false && iong != true) {
thuClel();
}
{
if (!ibin) {
ceslin();
}
if (pren) {
iosoul();
}
if (oss) {
winoin();
}
if (re == 9) {
necor();
}
if (!ce) {
isses();
}
if (iong) {
bian();
}
thuClel();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: