This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((di != 3 || almam() || du && mic <= 0) && u || oassan() < 2 && er < 3) {
...
...
// Pretend there is lots of code here
...
...
} else {
cenbir();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((er > 3 || oassan() > 2) && (!u || (mic >= 0 || !du) && !almam() && di == 3)) {
cenbir();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iepUabba() != 4 && il > 6 && plion() && datri() || bri <= tast && datri()) {
if (irre <= na) {
if (pri) {
if (uabe != 0) {
return true;
}
}
}
}
return false;
return uabe != 0 || pri || irre <= na || (iepUabba() != 4 && il > 6 && plion() || bri <= tast) && datri();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (bri >= tast && !plion() && irre >= na && !pri && uabe == 0 || il < 6 && irre >= na && !pri && uabe == 0 || iepUabba() == 4 && irre >= na && !pri && uabe == 0) {
if (uabe == 0) {
return false;
}
if (!pri) {
return false;
}
if (irre >= na) {
return false;
}
if (!datri()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (mo == true) {
eicHessge();
}
if (ec == true && mo != true) {
dronni();
}
if (va == true && mo != true && ec != true) {
redont();
}
if (rir == true && mo != true && ec != true && va != true) {
oorWhal();
} else if (nend == true && mo != true && ec != true && va != true && rir != true) {
liec();
} else if (ari == pi && mo != true && ec != true && va != true && rir != true && nend != true) {
pran();
}
if (es == false && mo != true && ec != true && va != true && rir != true && nend != true && ari != pi) {
ciic();
}
{
if (mo) {
eicHessge();
}
if (ec) {
dronni();
}
if (va) {
redont();
}
if (rir) {
oorWhal();
}
if (nend) {
liec();
}
if (ari == pi) {
pran();
}
if (!es) {
ciic();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: