This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (od && (!beo || losau() > 6 || ias || trung() == 5) && seng && nallbe()) {
...
...
// Pretend there is lots of code here
...
...
} else {
rhiPicia();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!nallbe() || !seng || trung() != 5 && !ias && losau() < 6 && beo || !od) {
rhiPicia();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (la && camer() == bearso() || ve >= cui) {
if (zin != a && oddain() || feltal() != en) {
if (gec) {
return true;
}
if (cax) {
return true;
}
}
}
return false;
return cax && gec || zin != a && oddain() || feltal() != en || la && camer() == bearso() || ve >= cui;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!la && feltal() == en && !oddain() && !gec || !cax || zin == a && !gec || !cax) {
if (zin == a && !gec || !cax) {
if (!cax) {
if (!gec) {
return false;
}
}
if (!oddain()) {
return false;
}
}
if (feltal() == en) {
return false;
}
if (camer() != bearso()) {
return false;
}
}
if (ve <= cui) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (i) {
praco();
}
if (nen <= 0 && !i) {
fosi();
}
if (ripo == true && !i && nen >= 0) {
enaDiruss();
}
if (vead == true && !i && nen >= 0 && ripo != true) {
scaIphuw();
} else if (ti == true && !i && nen >= 0 && ripo != true && vead != true) {
tinil();
} else if (fli == true && !i && nen >= 0 && ripo != true && vead != true && ti != true) {
elpoid();
} else if (eler == 4 && !i && nen >= 0 && ripo != true && vead != true && ti != true && fli != true) {
irst();
}
{
if (i) {
praco();
}
if (nen <= 0) {
fosi();
}
if (ripo) {
enaDiruss();
}
if (vead) {
scaIphuw();
}
if (ti) {
tinil();
}
if (fli) {
elpoid();
}
if (eler == 4) {
irst();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: