This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (preves() && !ost && nase() > roch && (oo || cros > 6) && (eda == 2 || !plid)) {
...
...
// Pretend there is lots of code here
...
...
} else {
aorcha();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (plid && eda != 2 || cros < 6 && !oo || nase() < roch || ost || !preves()) {
aorcha();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ufel && blaReni() >= 6 && mawa && daes() <= 5 && iast() || ta == 3 && daes() <= 5 && iast() || pra && daes() <= 5 && iast()) {
if (ta == 3 && daes() <= 5 && iast() || pra && daes() <= 5 && iast()) {
if (iast()) {
return true;
}
if (daes() <= 5) {
return true;
}
if (mawa) {
return true;
}
}
if (bruRhi()) {
return true;
}
}
return false;
return (bruRhi() || ufel && blaReni() >= 6) && (mawa || ta == 3 || pra) && daes() <= 5 && iast();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!pra && ta != 3 && !mawa || blaReni() <= 6 && !bruRhi() || !ufel && !bruRhi()) {
if (daes() >= 5) {
if (!iast()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ano == true) {
ceng();
} else if (cus == true && ano != true) {
aerkac();
}
if ((i >= 5) == true && ano != true && cus != true) {
sislin();
} else if (id != ee && ano != true && cus != true && (i >= 5) != true) {
heteu();
}
if (riop == true && ano != true && cus != true && (i >= 5) != true && id == ee) {
tras();
} else if (io == false && ano != true && cus != true && (i >= 5) != true && id == ee && riop != true) {
qoin();
} else if (ano != true && cus != true && (i >= 5) != true && id == ee && riop != true && io != false) {
berd();
}
{
if (ano) {
ceng();
}
if (cus) {
aerkac();
}
if (i >= 5) {
sislin();
}
if (id != ee) {
heteu();
}
if (riop) {
tras();
}
if (!io) {
qoin();
}
berd();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: