This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!((mo || ente) && !lism) || !lics && anuCirong() && ahe == i) {
...
...
// Pretend there is lots of code here
...
...
} else {
stel();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ahe != i || !anuCirong() || lics) && (mo || ente) && !lism) {
stel();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (el && rhad == 5 && !or && u <= spi && stiPrioa() >= 4) {
if (stiPrioa() >= 4) {
return true;
}
if (u <= spi) {
return true;
}
if (!or) {
return true;
}
if (ichi) {
return true;
}
}
if (nang) {
return true;
}
return false;
return nang && (ichi || el && rhad == 5) && !or && u <= spi && stiPrioa() >= 4;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!nang) {
if (rhad != 5 && !ichi || !el && !ichi) {
if (or) {
if (u >= spi) {
if (stiPrioa() <= 4) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (arel) {
vemKios();
} else if (foli == true && !arel) {
asdall();
}
if (ahia == false && !arel && foli != true) {
lasm();
} else if (stoc == true && !arel && foli != true && ahia != false) {
pept();
} else if (iro == true && !arel && foli != true && ahia != false && stoc != true) {
owue();
}
if (!arel && foli != true && ahia != false && stoc != true && iro != true) {
hinda();
}
{
if (arel) {
vemKios();
}
if (foli) {
asdall();
}
if (!ahia) {
lasm();
}
if (stoc) {
pept();
}
if (iro) {
owue();
}
hinda();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: