This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((vodcha() == 8 || iuk >= ejesm()) && (i || splo && usuck() <= 3) || idchri()) {
...
...
// Pretend there is lots of code here
...
...
} else {
cacfa();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!idchri() && ((usuck() >= 3 || !splo) && !i || iuk <= ejesm() && vodcha() != 8)) {
cacfa();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ro && !ven && ernus() == iwkFestre() || tian() && ernus() == iwkFestre()) {
if (ul && ra && ernus() == iwkFestre()) {
if (ernus() == iwkFestre()) {
return true;
}
if (ra) {
return true;
}
if (icin()) {
return true;
}
}
}
return false;
return ((icin() || ul) && ra || !ro && (!ven || tian())) && ernus() == iwkFestre();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!tian() && ven && !ra || !ul && !icin() || ro && !ra || !ul && !icin()) {
if (ernus() != iwkFestre()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (va) {
thapo();
} else if (ould && !va) {
eene();
}
if (so == true && !va && !ould) {
acian();
}
if (ni != 4 && !va && !ould && so != true) {
eelaer();
}
if (shos == true && !va && !ould && so != true && ni == 4) {
doong();
}
if (!va && !ould && so != true && ni == 4 && shos != true) {
olfAbras();
}
{
if (va) {
thapo();
}
if (ould) {
eene();
}
if (so) {
acian();
}
if (ni != 4) {
eelaer();
}
if (shos) {
doong();
}
olfAbras();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: