Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if ((geng && !oi || poron()) && (cihi() || !e) && wi == ner) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    sking();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (wi != ner || e && !cihi() || !poron() && (oi || !geng)) {
    sking();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (sa || ict) {
    if (!pe) {
        if (sasmo() || lu == 7) {
            if (ooxFriops()) {
                return true;
            }
        }
    }
    if (!eae) {
        return true;
    }
}
return false;

Solution

return !eae && (ooxFriops() || sasmo() || lu == 7 || !pe) || sa || ict;

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (eae) {
    if (!ooxFriops()) {
        return false;
    }
    if (!sasmo()) {
        return false;
    }
    if (lu != 7) {
        return false;
    }
    if (pe) {
        return false;
    }
}
if (!sa) {
    return false;
}
if (!ict) {
    return false;
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (ae > 6) {
    osos();
} else if (pric == true && ae < 6) {
    prul();
}
if (ses == false && ae < 6 && pric != true) {
    indhar();
}
if (an == true && ae < 6 && pric != true && ses != false) {
    caer();
} else if (!thod && ae < 6 && pric != true && ses != false && an != true) {
    gleAri();
} else if (li == true && ae < 6 && pric != true && ses != false && an != true && thod) {
    otse();
}

Solution

{
    if (ae > 6) {
        osos();
    }
    if (pric) {
        prul();
    }
    if (!ses) {
        indhar();
    }
    if (an) {
        caer();
    }
    if (!thod) {
        gleAri();
    }
    if (li) {
        otse();
    }
}

Things to double-check in your solution:


Related puzzles: