This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((begiol() == ioblul() || pran) && tidza() == darne() && pesm || sceTus() || !e) {
...
...
// Pretend there is lots of code here
...
...
} else {
pisild();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (e && !sceTus() && (!pesm || tidza() != darne() || !pran && begiol() != ioblul())) {
pisild();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (uss > 1 && priChotel() == 1 || inqid() && priChotel() == 1 || ifoa == 0) {
if (foddir()) {
return true;
}
if (!tuss) {
return true;
}
if (dioPead() > 1) {
return true;
}
}
return false;
return dioPead() > 1 && !tuss && foddir() || (uss > 1 || inqid()) && priChotel() == 1 || ifoa == 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!inqid() && uss < 1 && !foddir() || tuss || dioPead() < 1) {
if (dioPead() < 1) {
if (tuss) {
if (!foddir()) {
return false;
}
}
}
if (priChotel() != 1) {
return false;
}
}
if (ifoa != 0) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (a == true) {
klat();
} else if (lel <= 8 && a != true) {
neng();
}
if ((flel <= ol) == true && a != true && lel >= 8) {
crarbe();
}
if (de == true && a != true && lel >= 8 && (flel <= ol) != true) {
idront();
} else if (gi >= 6 && a != true && lel >= 8 && (flel <= ol) != true && de != true) {
foaca();
}
if (a != true && lel >= 8 && (flel <= ol) != true && de != true && gi <= 6) {
lotcae();
}
{
if (a) {
klat();
}
if (lel <= 8) {
neng();
}
if (flel <= ol) {
crarbe();
}
if (de) {
idront();
}
if (gi >= 6) {
foaca();
}
lotcae();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: