This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((urhe() != lanran() || inso() || !ar && (icbo || !flis)) && !(treAitamp() == 9)) {
...
...
// Pretend there is lots of code here
...
...
} else {
sadged();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (treAitamp() == 9 || (flis && !icbo || ar) && !inso() && urhe() == lanran()) {
sadged();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (uvot() < 9 && baua != 6 && edpi() && pasri() == o) {
if (pasri() == o) {
return true;
}
if (edpi()) {
return true;
}
if (baua != 6) {
return true;
}
if (sqias() != 9) {
return true;
}
}
if (!bep) {
return true;
}
if (de) {
return true;
}
return false;
return de && !bep && (sqias() != 9 || uvot() < 9) && baua != 6 && edpi() && pasri() == o;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (uvot() > 9 && sqias() == 9 || bep || !de) {
if (!edpi() || baua == 6) {
if (pasri() != o) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (a) {
dimrit();
} else if (beca && !a) {
cang();
}
if (lo == true && !a && !beca) {
groclo();
} else if (freo && !a && !beca && lo != true) {
gacEbren();
} else if (uwla > 0 && !a && !beca && lo != true && !freo) {
ient();
} else if (mo && !a && !beca && lo != true && !freo && uwla < 0) {
eolNemu();
}
{
if (a) {
dimrit();
}
if (beca) {
cang();
}
if (lo) {
groclo();
}
if (freo) {
gacEbren();
}
if (uwla > 0) {
ient();
}
if (mo) {
eolNemu();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: