This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (re && a && diro() && (qoud() || !(si && !saun))) {
...
...
// Pretend there is lots of code here
...
...
} else {
squng();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (si && !saun && !qoud() || !diro() || !a || !re) {
squng();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pra) {
if (ri && u != 1 && irgiap() || braun() >= 1) {
if (plis && irgiap() || braun() >= 1) {
if (braun() >= 1) {
if (irgiap()) {
return true;
}
}
if (ra != peknak()) {
return true;
}
}
}
}
return false;
return (ra != peknak() || plis || ri && u != 1) && (irgiap() || braun() >= 1) || pra;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (u == 1 && !plis && ra == peknak() || !ri && !plis && ra == peknak()) {
if (!irgiap()) {
return false;
}
if (braun() <= 1) {
return false;
}
}
if (!pra) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (bi == true) {
erlClen();
}
if (mo == false && bi != true) {
cesm();
}
if ((oves >= 5) == true && bi != true && mo != false) {
chism();
} else if ((veni <= haci) == true && bi != true && mo != false && (oves >= 5) != true) {
bouUdsaug();
}
if ((niis >= lo) == true && bi != true && mo != false && (oves >= 5) != true && (veni <= haci) != true) {
tredus();
} else if (bi != true && mo != false && (oves >= 5) != true && (veni <= haci) != true && (niis >= lo) != true) {
etia();
}
{
if (bi) {
erlClen();
}
if (!mo) {
cesm();
}
if (oves >= 5) {
chism();
}
if (veni <= haci) {
bouUdsaug();
}
if (niis >= lo) {
tredus();
}
etia();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: