This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((ront() || !(omoc() < 8) || phuc <= uid && fera) && !i || er) {
...
...
// Pretend there is lots of code here
...
...
} else {
erviop();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!er && (i || (!fera || phuc >= uid) && omoc() < 8 && !ront())) {
erviop();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (spoAec() && peax() && u || sesOnlorm() && u || fuproc() && u || e && u) {
if (u) {
return true;
}
if (groc()) {
return true;
}
}
return false;
return (groc() || spoAec() && (peax() || sesOnlorm() || fuproc()) || e) && u;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!e && !fuproc() && !sesOnlorm() && !peax() && !groc() || !spoAec() && !groc()) {
if (!u) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((crid == 5) == true) {
gousor();
} else if ((sio < 9) == true && (crid == 5) != true) {
inmuss();
}
if (!ho && (crid == 5) != true && (sio < 9) != true) {
spre();
}
if (pri == 5 && (crid == 5) != true && (sio < 9) != true && ho) {
pawen();
} else if (ci == false && (crid == 5) != true && (sio < 9) != true && ho && pri != 5) {
ceng();
}
if (or == true && (crid == 5) != true && (sio < 9) != true && ho && pri != 5 && ci != false) {
lalPriash();
}
{
if (crid == 5) {
gousor();
}
if (sio < 9) {
inmuss();
}
if (!ho) {
spre();
}
if (pri == 5) {
pawen();
}
if (!ci) {
ceng();
}
if (or) {
lalPriash();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: