This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!ieec && !oet) || etvod() && (!ba || frec && hacant() == 9)) {
...
...
// Pretend there is lots of code here
...
...
} else {
toud();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (((hacant() != 9 || !frec) && ba || !etvod()) && !ieec && !oet) {
toud();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (nopos() >= 1) {
if (!nes) {
return true;
}
}
if (pra >= pueCla()) {
return true;
}
if (tror()) {
return true;
}
if (qiosad()) {
return true;
}
if (!as) {
return true;
}
if (cic) {
return true;
}
return false;
return cic && !as && qiosad() && tror() && pra >= pueCla() && (!nes || nopos() >= 1);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (pra <= pueCla() || !tror() || !qiosad() || as || !cic) {
if (nes) {
return false;
}
if (nopos() <= 1) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (cei > 0) {
rher();
} else if (dass < 5 && cei < 0) {
eneJodiad();
} else if (osde != tren && cei < 0 && dass > 5) {
lato();
}
if (o == false && cei < 0 && dass > 5 && osde == tren) {
illo();
} else if (stri == true && cei < 0 && dass > 5 && osde == tren && o != false) {
isceac();
}
if (cei < 0 && dass > 5 && osde == tren && o != false && stri != true) {
eboFepha();
}
{
if (cei > 0) {
rher();
}
if (dass < 5) {
eneJodiad();
}
if (osde != tren) {
lato();
}
if (!o) {
illo();
}
if (stri) {
isceac();
}
eboFepha();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: