This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(pelRidin() > 0 || mentti() >= 6 && papes()) || !pio || strog() || !mo) {
...
...
// Pretend there is lots of code here
...
...
} else {
phion();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (mo && !strog() && pio && (pelRidin() > 0 || mentti() >= 6 && papes())) {
phion();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (garac()) {
if (uahe()) {
if (!em) {
return true;
}
}
if (gla) {
return true;
}
}
if (dilru() == 9) {
return true;
}
if (denmuc()) {
return true;
}
if (stoCusi()) {
return true;
}
return false;
return stoCusi() && denmuc() && dilru() == 9 && (gla && (!em || uahe()) || garac());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (dilru() != 9 || !denmuc() || !stoCusi()) {
if (!gla) {
if (em) {
return false;
}
if (!uahe()) {
return false;
}
}
if (!garac()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ci == true) {
eisSqa();
}
if ((wuc <= 7) == true && ci != true) {
cakac();
} else if (ar == true && ci != true && (wuc <= 7) != true) {
ucwre();
} else if (dru == true && ci != true && (wuc <= 7) != true && ar != true) {
tudo();
} else if (raru && ci != true && (wuc <= 7) != true && ar != true && dru != true) {
bahel();
}
if (jort == 6 && ci != true && (wuc <= 7) != true && ar != true && dru != true && !raru) {
sest();
}
{
if (ci) {
eisSqa();
}
if (wuc <= 7) {
cakac();
}
if (ar) {
ucwre();
}
if (dru) {
tudo();
}
if (raru) {
bahel();
}
if (jort == 6) {
sest();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: