This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!scro && ic && nielad() && !so && (nu == 8 || zet == 4)) {
...
...
// Pretend there is lots of code here
...
...
} else {
nemaen();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (zet != 4 && nu != 8 || so || !nielad() || !ic || scro) {
nemaen();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rons || tast() < 8 && azir() && er > efeThic() || i && er > efeThic()) {
if (ieel == tolkic()) {
if (!lom) {
return true;
}
}
}
return false;
return !lom || ieel == tolkic() || rons || tast() < 8 && (azir() || i) && er > efeThic();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!i && !azir() && !rons && ieel != tolkic() && lom || tast() > 8 && !rons && ieel != tolkic() && lom) {
if (lom) {
return false;
}
if (ieel != tolkic()) {
return false;
}
if (!rons) {
return false;
}
if (er < efeThic()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (onse <= 8 == true) {
hocon();
}
if (es == suc && onse <= 8 != true) {
ceza();
}
if (tu == false && onse <= 8 != true && es != suc) {
poqiar();
}
if (da == false && onse <= 8 != true && es != suc && tu != false) {
ongfo();
}
if (nur == true && onse <= 8 != true && es != suc && tu != false && da != false) {
ioum();
}
if (onse <= 8 != true && es != suc && tu != false && da != false && nur != true) {
dedfoi();
}
{
if (onse <= 8) {
hocon();
}
if (es == suc) {
ceza();
}
if (!tu) {
poqiar();
}
if (!da) {
ongfo();
}
if (nur) {
ioum();
}
dedfoi();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: