This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(crau && !e) || !(ci && gle) || cerFafi() || edwas()) {
...
...
// Pretend there is lots of code here
...
...
} else {
piedha();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!edwas() && !cerFafi() && ci && gle && crau && !e) {
piedha();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (xen && jeijul() || thaxoc() || !sor && jeijul() || thaxoc() || !tes && jeijul() || thaxoc() || cuta() <= 5 && jeijul() || thaxoc()) {
if (treIffspa()) {
return true;
}
}
return false;
return treIffspa() || (xen || !sor || !tes || cuta() <= 5) && (jeijul() || thaxoc());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (cuta() >= 5 && tes && sor && !xen && !treIffspa()) {
if (!treIffspa()) {
return false;
}
if (!jeijul()) {
return false;
}
if (!thaxoc()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (iorm == true) {
nuara();
} else if (gla == true && iorm != true) {
marcu();
} else if (smue == false && iorm != true && gla != true) {
terast();
}
if (ba == true && iorm != true && gla != true && smue != false) {
hosIas();
} else if (sa && iorm != true && gla != true && smue != false && ba != true) {
monris();
}
if (iorm != true && gla != true && smue != false && ba != true && !sa) {
tucSeant();
}
{
if (iorm) {
nuara();
}
if (gla) {
marcu();
}
if (!smue) {
terast();
}
if (ba) {
hosIas();
}
if (sa) {
monris();
}
tucSeant();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: