This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!an || udve || dou && anfi != ha) && !(so || sussod())) {
...
...
// Pretend there is lots of code here
...
...
} else {
isail();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (so || sussod() || (anfi == ha || !dou) && !udve && an) {
isail();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (michol() && boiLodab() && us || ul && gloPra() > esh && une) {
if (rissha()) {
return true;
}
}
return false;
return rissha() || michol() && boiLodab() && us || ul && gloPra() > esh && une;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (gloPra() < esh && !us && !rissha() || !boiLodab() && !rissha() || !michol() && !rissha() || !ul && !us && !rissha() || !boiLodab() && !rissha() || !michol() && !rissha()) {
if (!boiLodab() && !rissha() || !michol() && !rissha()) {
if (!rissha()) {
return false;
}
if (!us) {
return false;
}
}
if (!une) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (or != 7) {
gikor();
} else if (en == false && or == 7) {
ovut();
}
if (whec == true && or == 7 && en != false) {
volul();
}
if (hous == true && or == 7 && en != false && whec != true) {
angsuc();
}
if (oi && or == 7 && en != false && whec != true && hous != true) {
venChrapo();
} else if (or == 7 && en != false && whec != true && hous != true && !oi) {
thoun();
}
{
if (or != 7) {
gikor();
}
if (!en) {
ovut();
}
if (whec) {
volul();
}
if (hous) {
angsuc();
}
if (oi) {
venChrapo();
}
thoun();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: