This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((ul > 6 || !o || sodla() && is) && (!shesm() || assper())) {
...
...
// Pretend there is lots of code here
...
...
} else {
siome();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!assper() && shesm() || (!is || !sodla()) && o && ul < 6) {
siome();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!us && hingfo() && doep && be == 9 && hu == 0) {
if (hu == 0) {
return true;
}
if (be == 9) {
return true;
}
if (doep) {
return true;
}
if (etiOnba() < ca) {
return true;
}
}
if (ciadas() != orru) {
return true;
}
return false;
return ciadas() != orru && (etiOnba() < ca || !us && hingfo()) && doep && be == 9 && hu == 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!doep || !hingfo() && etiOnba() > ca || us && etiOnba() > ca || ciadas() == orru) {
if (be != 9) {
if (hu != 0) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (we >= tia) {
pribla();
} else if ((os >= 8) == true && we <= tia) {
qenLirso();
}
if (aric == true && we <= tia && (os >= 8) != true) {
skick();
}
if (an == true && we <= tia && (os >= 8) != true && aric != true) {
breDalre();
}
if (ocs == true && we <= tia && (os >= 8) != true && aric != true && an != true) {
dedUnpout();
} else if (e == true && we <= tia && (os >= 8) != true && aric != true && an != true && ocs != true) {
eldes();
}
{
if (we >= tia) {
pribla();
}
if (os >= 8) {
qenLirso();
}
if (aric) {
skick();
}
if (an) {
breDalre();
}
if (ocs) {
dedUnpout();
}
if (e) {
eldes();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: